From d70e4e7386fce32338ff5a2998d5361161172b11 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mathieu=20B=C3=A9rard?= Date: Fri, 15 Sep 2006 12:45:18 +0000 Subject: [PATCH] * Documentation update * Fix by Holger Nelson - display bug in nbsmi - sysfs vs procfs synchro fix in lcd --- doc/BUGS | 1 + laptop.h | 2 +- lcd.c | 8 ++++++-- nbsmi.c | 4 ++-- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/BUGS b/doc/BUGS index c17999a..c629259 100644 --- a/doc/BUGS +++ b/doc/BUGS @@ -11,6 +11,7 @@ Bugs and problems in omnibook module code implementation. * Reenabling wifi adapter after previous disabling is broken on Toshiba Satellite M100 (ipw3945) +* Real support of ectype 14 is still missing * See http://sourceforge.net/tracker/?atid=868542&group_id=174260&func=browse for sf.net bug tracking system. diff --git a/laptop.h b/laptop.h index 6a68226..58df9b3 100644 --- a/laptop.h +++ b/laptop.h @@ -490,11 +490,11 @@ static struct dmi_system_id omnibook_ids[] __initdata = { }, { .callback = dmi_matched, + .ident = "Toshiba Satellite 2430", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), DMI_MATCH(DMI_PRODUCT_NAME, "Satellite 2430"), }, - .ident = "Toshiba Satellite 2430", .driver_data = (void*) XE3GF }, { diff --git a/lcd.c b/lcd.c index f138e3b..c6ddfcd 100644 --- a/lcd.c +++ b/lcd.c @@ -94,8 +94,12 @@ static int omnibook_brightness_write(char *buffer, struct omnibook_operation *io brgt = simple_strtoul(buffer, &endp, 10); if ((endp == buffer) || (brgt < 0) || (brgt > omnibook_max_brightness)) return -EINVAL; - else + else { io_op->backend->byte_write(io_op, brgt); +#ifdef CONFIG_OMNIBOOK_BACKLIGHT + omnibookbl_data.brightness=brgt; +#endif + } } return 0; } @@ -103,7 +107,7 @@ static int omnibook_brightness_write(char *buffer, struct omnibook_operation *io static int __init omnibook_brightness_init(struct omnibook_operation *io_op) { /* - * FIXME: What is exactly de max value for each model ? + * FIXME: What is exactly the max value for each model ? * I know that it's 7 for the TSM30X, TSM40 and TSA105 * and previous versions of this driver (wrongly) assumed it was 10 for * all models. diff --git a/nbsmi.c b/nbsmi.c index 2f4a074..36b22ac 100644 --- a/nbsmi.c +++ b/nbsmi.c @@ -578,7 +578,7 @@ static int omnibook_nbmsi_display_set(const struct omnibook_operation *io_op, un { int retval; int i; - u8 matched = 0; + u8 matched = 255; for (i = 0; i < ARRAY_SIZE(nbsmi_display_mode_list); i++) { if (nbsmi_display_mode_list[i] == state) { @@ -586,7 +586,7 @@ static int omnibook_nbmsi_display_set(const struct omnibook_operation *io_op, un break; } } - if (!matched) { + if(matched==255) { printk("Display mode %x is unsupported.\n", state); return -EINVAL; } -- 2.43.5