From d02db1b47718f96757e1d403e275bb1438ab6921 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Michal=20Mal=C3=BD?= Date: Sun, 29 Mar 2015 15:19:31 +0200 Subject: [PATCH] Fix memory leak in read_string_at_offset() --- libhpcs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libhpcs.c b/libhpcs.c index c6d9e8d..3f9eef5 100644 --- a/libhpcs.c +++ b/libhpcs.c @@ -773,6 +773,7 @@ static enum HPCS_ParseCode read_string_at_offset(FILE* datafile, const HPCS_offs char* string; uint8_t str_length; size_t r; + enum HPCS_ParseCode ret; fseek(datafile, offset, SEEK_SET); if (feof(datafile)) @@ -801,11 +802,13 @@ static enum HPCS_ParseCode read_string_at_offset(FILE* datafile, const HPCS_offs #ifdef _WIN32 /* String is stored as native Windows WCHAR */ - return __win32_wchar_to_utf8(result, string); + ret = __win32_wchar_to_utf8(result, string); #else /* Explicitly convert from UTF-16LE (internal WCHAR representation) */ - return __unix_wchar_to_utf8(result, string, str_length * SEGMENT_SIZE); + ret = __unix_wchar_to_utf8(result, string, str_length * SEGMENT_SIZE); #endif + free(string); + return ret; } /** Platform-specific functions */ -- 2.43.5