From: Michal Malý <madcatxster@prifuk.cz>
Date: Thu, 19 Dec 2013 22:04:36 +0000 (+0100)
Subject: Add "Repeat" field.
X-Git-Tag: 0.4a~9
X-Git-Url: https://gitweb.devoid-pointer.net/?a=commitdiff_plain;h=d69951edf72e711def1b93919067326b438ab183;p=FFBChecker.git

Add "Repeat" field.
---

diff --git a/ffbdevice.cpp b/ffbdevice.cpp
index cdd0ea1..9df7e72 100644
--- a/ffbdevice.cpp
+++ b/ffbdevice.cpp
@@ -265,6 +265,8 @@ bool FFBDevice::startEffect(const int idx, FFBEffectTypes type, std::shared_ptr<
     return false;
   }
 
+  qDebug() << kernelEff->u.condition[0].center << kernelEff->u.condition[0].deadband << kernelEff->u.condition[1].center << kernelEff->u.condition[1].deadband;
+
   int ret = uploadEffect(kernelEff);
   if (ret < 0) {
     QMessageBox::critical(nullptr, "FFB Device", "Effect could not have been uploaded, error code: " + QString::number(ret));
@@ -282,7 +284,7 @@ bool FFBDevice::startEffect(const int idx, FFBEffectTypes type, std::shared_ptr<
   struct input_event evt;
   evt.type = EV_FF;
   evt.code = kernelEff->id;
-  evt.value = 1;
+  evt.value = m_effects[idx]->parameters()->repeat;
 
   ret = write(c_fd, &evt, sizeof(struct input_event));
   if (ret != sizeof(struct input_event)) {
diff --git a/ffbeffect.cpp b/ffbeffect.cpp
index 5e93257..21fa75a 100644
--- a/ffbeffect.cpp
+++ b/ffbeffect.cpp
@@ -32,6 +32,11 @@ bool FFBEffect::checkGenericParameters(const std::shared_ptr<FFBEffectParameters
   if (!GlobalSettings::GS()->doSanityChecks)
     return true;
 
+  if (params->repeat < 1) {
+    reportError("Effect must be played back at least once.");
+    return false;
+  }
+
   if (!checkBoundsInclusive(params->direction, 0, 0xFFFF)) {
     reportError("Direction out of bounds.");
     return false;
diff --git a/ffbeffectparameters.cpp b/ffbeffectparameters.cpp
index 9f3d705..cf6a63e 100644
--- a/ffbeffectparameters.cpp
+++ b/ffbeffectparameters.cpp
@@ -2,6 +2,7 @@
 
 FFBEffectParameters::FFBEffectParameters() :
   direction(0),
+  repeat(1),
   replayDelay(0),
   replayLength(0)
 {
@@ -15,6 +16,14 @@ bool FFBEffectParameters::directionFromString(const QString& direction)
   return ok;
 }
 
+bool FFBEffectParameters::repeatFromString(const QString& repeat)
+{
+  bool ok;
+  this->repeat = repeat.toInt(&ok);
+
+  return ok;
+}
+
 bool FFBEffectParameters::replayDelayFromString(const QString& replayDelay)
 {
   bool ok;
diff --git a/ffbeffectparameters.h b/ffbeffectparameters.h
index f88b5f0..9db30d9 100644
--- a/ffbeffectparameters.h
+++ b/ffbeffectparameters.h
@@ -12,10 +12,12 @@ public:
   virtual ~FFBEffectParameters();
 
   bool directionFromString(const QString& direction);
+  bool repeatFromString(const QString& repeat);
   bool replayDelayFromString(const QString& replayDelay);
   bool replayLengthFromString(const QString& replayLength);
 
   int direction;
+  int repeat;
   int replayDelay;
   int replayLength;
 };
diff --git a/mainwindow.cpp b/mainwindow.cpp
index 2869120..50a62e9 100644
--- a/mainwindow.cpp
+++ b/mainwindow.cpp
@@ -343,6 +343,10 @@ bool MainWindow::readGeneralEffectParameters(std::shared_ptr<FFBEffectParameters
     QMessageBox::warning(this, res_inputFormatErrCap, "Invalid data in field \"direction\"");
     return false;
   }
+  if (!params->repeatFromString(ui->qle_repeat->text())) {
+    QMessageBox::warning(this, res_inputFormatErrCap, "Invalid data in field \"Replay\"");
+    return false;
+  }
   if (!params->replayDelayFromString(ui->qle_replayDelay->text())) {
     QMessageBox::warning(this, res_inputFormatErrCap, "Invalid data in field \"Replay delay\"");
     return false;
diff --git a/mainwindow.ui b/mainwindow.ui
index 2292c7f..475c256 100644
--- a/mainwindow.ui
+++ b/mainwindow.ui
@@ -157,6 +157,23 @@
         </property>
        </widget>
       </item>
+      <item row="2" column="0">
+       <widget class="QLabel" name="ql_repeat">
+        <property name="text">
+         <string>Repeat:</string>
+        </property>
+       </widget>
+      </item>
+      <item row="2" column="1">
+       <widget class="QLineEdit" name="qle_repeat">
+        <property name="text">
+         <string>1</string>
+        </property>
+        <property name="alignment">
+         <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+        </property>
+       </widget>
+      </item>
      </layout>
     </item>
     <item>