From: Michal Malý <madcatxster@devoid-pointer.net>
Date: Sun, 27 Sep 2015 23:26:06 +0000 (+0200)
Subject: Fix an overflow in constant force scaling in the testing module
X-Git-Url: https://gitweb.devoid-pointer.net/?a=commitdiff_plain;h=6c803ef8a0b1be6cd161910b9883c303509420e2;p=KLGD_FF_plugin.git

Fix an overflow in constant force scaling in the testing module
---

diff --git a/testmod/klgdff.c b/testmod/klgdff.c
index 8b57b75..c80995b 100644
--- a/testmod/klgdff.c
+++ b/testmod/klgdff.c
@@ -145,7 +145,7 @@ static int klgdff_start(struct klgd_command_stream *s, const struct ff_effect *e
 	{
 		s32 x;
 		s32 y;
-		s16 level = effect->u.constant.level * gain / 0xFFFF;
+		s32 level = effect->u.constant.level * gain / 0xFFFF;
 
 		ffpl_lvl_dir_to_x_y(level, effect->direction, &x, &y);
 		text = kasprintf(GFP_KERNEL, "Playing FF_CONSTANT, level: %d, dir: %u, X: %d, Y: %d", level, effect->direction, x, y);
@@ -196,7 +196,7 @@ static int klgdff_update(struct klgd_command_stream *s, const struct ff_effect *
 	{
 		s32 x;
 		s32 y;
-		s16 level = effect->u.constant.level * gain / 0xFFFF;
+		s32 level = effect->u.constant.level * gain / 0xFFFF;
 
 		ffpl_lvl_dir_to_x_y(level, effect->direction, &x, &y);
 		text = kasprintf(GFP_KERNEL, "Updating FF_CONSTANT, level: %d, dir: %u, X: %d, Y: %d", level, effect->direction, x, y);
@@ -247,7 +247,7 @@ static int klgdff_up_start(struct klgd_command_stream *s, const struct ff_effect
 	{
 		s32 x;
 		s32 y;
-		s16 level = effect->u.constant.level * gain / 0xFFFF;
+		s32 level = effect->u.constant.level * gain / 0xFFFF;
 
 		ffpl_lvl_dir_to_x_y(level, effect->direction, &x, &y);
 		text = kasprintf(GFP_KERNEL, "Uploading and starting FF_CONSTANT, level: %d, dir: %u, X: %d, Y: %d", level, effect->direction, x, y);