From: Michal MalĂ˝ Date: Sat, 7 Dec 2013 19:47:54 +0000 (+0100) Subject: Fix limits of valid values of effect parameters. X-Git-Tag: 0.2d~3 X-Git-Url: https://gitweb.devoid-pointer.net/?a=commitdiff_plain;h=33286482722ff26fc632d11eec2d85a9b98268b2;p=FFBChecker.git Fix limits of valid values of effect parameters. --- diff --git a/ffbconstanteffect.cpp b/ffbconstanteffect.cpp index c9616b4..879dd11 100644 --- a/ffbconstanteffect.cpp +++ b/ffbconstanteffect.cpp @@ -39,18 +39,18 @@ bool FFBConstantEffect::setParameters(const std::shared_ptrdoSanityChecks) { - if (!checkBoundsInclusive(params->attackLength, 0, 0xFFFF)){ + if (!checkBoundsInclusive(params->attackLength, 0, 0x7FFF)){ reportError("Attack length out of bounds"); return false; } - if (!checkBoundsInclusive(params->attackLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->attackLevel, 0, 0x7FFF)) { reportError("Attack level out of bounds"); return false; - } if (!checkBoundsInclusive(params->fadeLength, 0, 0xFFFF)) { + } if (!checkBoundsInclusive(params->fadeLength, 0, 0x7FFF)) { reportError("Fade length out of bounds"); return false; } - if (!checkBoundsInclusive(params->fadeLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->fadeLevel, 0, 0x7FFF)) { reportError("Fade level out of bounds"); return false; } diff --git a/ffbeffect.cpp b/ffbeffect.cpp index 98a49b8..5e93257 100644 --- a/ffbeffect.cpp +++ b/ffbeffect.cpp @@ -37,12 +37,12 @@ bool FFBEffect::checkGenericParameters(const std::shared_ptrreplayDelay, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->replayDelay, 0, 0x7FFF)) { reportError("Replay delay out of bounds."); return false; } - if (!checkBoundsInclusive(params->replayLength, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->replayLength, 0, 0x7FFF)) { reportError("Replay length out of bounds."); return false; } diff --git a/ffbperiodiceffect.cpp b/ffbperiodiceffect.cpp index c9ff718..b07200a 100644 --- a/ffbperiodiceffect.cpp +++ b/ffbperiodiceffect.cpp @@ -64,22 +64,22 @@ bool FFBPeriodicEffect::setParameters(const std::shared_ptrdoSanityChecks) { - if (!checkBoundsInclusive(params->attackLength, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->attackLength, 0, 0x7FFF)) { reportError("Attack length out of bounds."); return false; } - if (!checkBoundsInclusive(params->attackLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->attackLevel, 0, 0x7FFF)) { reportError("Attack level out of bounds."); return false; } - if (!checkBoundsInclusive(params->fadeLength, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->fadeLength, 0, 0x7FFF)) { reportError("Fade length out of bounds."); return false; } - if (!checkBoundsInclusive(params->fadeLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->fadeLevel, 0, 0x7FFF)) { reportError("Fade level out of bounds."); return false; } @@ -94,12 +94,12 @@ bool FFBPeriodicEffect::setParameters(const std::shared_ptrperiod, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->period, 0, 0x7FFF)) { reportError("Period out of bounds."); return false; } - if (!checkBoundsInclusive(params->phase, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->phase, 0, 0x7FFF)) { reportError("Phase out of bounds."); return false; } diff --git a/ffbrampeffect.cpp b/ffbrampeffect.cpp index 97c3afe..3428b26 100644 --- a/ffbrampeffect.cpp +++ b/ffbrampeffect.cpp @@ -42,22 +42,22 @@ bool FFBRampEffect::setParameters(const std::shared_ptr return false; if (GlobalSettings::GS()->doSanityChecks) { - if (!checkBoundsInclusive(params->attackLength, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->attackLength, 0, 0x7FFF)) { reportError("Attack length out of bounds."); return false; } - if (!checkBoundsInclusive(params->attackLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->attackLevel, 0, 0x7FFF)) { reportError("Attack level out of bounds."); return false; } - if (!checkBoundsInclusive(params->fadeLength, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->fadeLength, 0, 0x7FFF)) { reportError("Fade length out of bounds."); return false; } - if (!checkBoundsInclusive(params->fadeLevel, 0, 0xFFFF)) { + if (!checkBoundsInclusive(params->fadeLevel, 0, 0x7FFF)) { reportError("Fade level out of bounds."); return false; }