* Documentation update

* Fix by Holger Nelson
  - display bug in nbsmi
  - sysfs vs procfs synchro fix in lcd

diff --git a/doc/BUGS b/doc/BUGS
index c17999af1c5d058d63cfb5352867d0f8faf038de..c629259c5b4c2eb1b189edcee88588eb5daf7ab8 100644 (file)
--- a/doc/BUGS
+++ b/doc/BUGS
@@ -11,6 +11,7 @@ Bugs and problems in omnibook module code
   implementation.
 * Reenabling wifi adapter after previous disabling is broken on 
   Toshiba Satellite M100 (ipw3945)
+* Real support of ectype 14 is still missing 
 * See http://sourceforge.net/tracker/?atid=868542&group_id=174260&func=browse
   for sf.net bug tracking system.
 

diff --git a/laptop.h b/laptop.h
index 6a6822644003228ee856568892c86fb4076bf8fc..58df9b32b7fef6cd83cffb657dbb7a4931c82a03 100644 (file)
--- a/laptop.h
+++ b/laptop.h
@@ -490,11 +490,11 @@ static struct  dmi_system_id omnibook_ids[] __initdata = {
        },
        {
                .callback = dmi_matched,
+               .ident = "Toshiba Satellite 2430",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "Satellite 2430"),
                },
-               .ident = "Toshiba Satellite 2430",
                .driver_data = (void*) XE3GF
        },
        {

diff --git a/lcd.c b/lcd.c
index f138e3bea1f63d4b1bfd0d93b79a232dd4486118..c6ddfcd811771a6d59223aefddab1220234c7c1c 100644 (file)
--- a/lcd.c
+++ b/lcd.c
@@ -94,8 +94,12 @@ static int omnibook_brightness_write(char *buffer, struct omnibook_operation *io
                brgt = simple_strtoul(buffer, &endp, 10);
                if ((endp == buffer) || (brgt < 0) || (brgt > omnibook_max_brightness))
                        return -EINVAL;
-               else
+               else {
                        io_op->backend->byte_write(io_op, brgt);
+#ifdef CONFIG_OMNIBOOK_BACKLIGHT
+                       omnibookbl_data.brightness=brgt;
+#endif                 
+               }
        }
        return 0;
 }
@@ -103,7 +107,7 @@ static int omnibook_brightness_write(char *buffer, struct omnibook_operation *io
 static int __init omnibook_brightness_init(struct omnibook_operation *io_op)
 {
        /*
-        * FIXME: What is exactly de max value for each model ?
+        * FIXME: What is exactly the max value for each model ?
         * I know that it's 7 for the TSM30X, TSM40 and TSA105
         * and previous versions of this driver (wrongly) assumed it was 10 for
         * all models.

diff --git a/nbsmi.c b/nbsmi.c
index 2f4a074a3a81693cb360fbcdf2736f239bf31618..36b22ac9a46e23ce25ef2eeed49f694a6f29afb2 100644 (file)
--- a/nbsmi.c
+++ b/nbsmi.c
@@ -578,7 +578,7 @@ static int omnibook_nbmsi_display_set(const struct omnibook_operation *io_op, un
 {
        int retval;
        int i;
-       u8 matched = 0;
+       u8 matched = 255;
 
        for (i = 0; i < ARRAY_SIZE(nbsmi_display_mode_list); i++) {
                if (nbsmi_display_mode_list[i] == state) {
@@ -586,7 +586,7 @@ static int omnibook_nbmsi_display_set(const struct omnibook_operation *io_op, un
                        break;
                }
        }
-       if (!matched) {
+       if(matched==255) {
                printk("Display mode %x is unsupported.\n", state);
                return -EINVAL;
        }